Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apiextensions DSL uses NonNamespaceOperation for CustomResourceDefinitions #2747

Merged

Conversation

rohanKanojia
Copy link
Member

CustomResourceDefinitions api DSL should not have inNamespace exposed.
This was due to my mistake while adding apiextensions() DSL in
#2359

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@metacosm
Copy link
Collaborator

@iocanel @manusa and I have discussed some related changes so many we should hold off merging for now?

@rohanKanojia
Copy link
Member Author

ohk, let's hold merge.

@manusa
Copy link
Member

manusa commented Feb 2, 2021

Hi, I think that since this PR just fixes a bug, we can safely merge it. It makes sense to make the DSL consistent with the API even if this is going to be refactored in the future.

Refactoring should be covered in future PRs.

…tions

CustomResourceDefinitions api DSL should not have inNamespace exposed.
This was due to my mistake while adding apiextensions() DSL in
fabric8io#2359
@rohanKanojia rohanKanojia force-pushed the pr/fix-apiextensions-returntype branch from 12b5daa to 23319fc Compare February 18, 2021 15:04
@rohanKanojia
Copy link
Member Author

I agree with Marc here we can safely merge this PR.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants