From 16c9850334aa1d98294677b89529bf37dbbafe1d Mon Sep 17 00:00:00 2001 From: manusa Date: Fri, 8 May 2020 15:32:22 +0200 Subject: [PATCH] fix: Uber Jar includes merged service entry for multiple implementations of the same interface Apparently uber-jar configuration has been wrong for a while now. Service entry declarations were being lost because they collided both for openshift-client and for kubernetes-client modules. uberjar: `maven-shade-plugin:3.2.3:shade ` ``` [WARNING] kubernetes-client-4.10-SNAPSHOT.jar, kubernetes-openshift-uberjar-4.10-SNAPSHOT.jar, openshift-client-4.10-SNAPSHOT.jar define 3 overlapping resources: [WARNING] - META-INF/services/io.fabric8.kubernetes.client.ExtensionAdapter [WARNING] - META-INF/services/io.fabric8.kubernetes.client.ResourceHandler [WARNING] - META-INF/services/io.fabric8.kubernetes.client.ServiceToURLProvider ``` See: https://maven.apache.org/plugins/maven-shade-plugin/examples/resource-transformers.html#ServicesResourceTransformer --- CHANGELOG.md | 1 + uberjar/pom.xml | 3 +++ 2 files changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7e289cdd2a8..bd106bf8d7a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -12,6 +12,7 @@ ### 4.10.1 (2020-05-06) #### Bugs * Fix #2189: Change package names of Resource Operation classes in order to avoid duplicates Operation classes +* Fix #2066: Uber Jar includes merged service entry for multiple implementations of the same interface #### Improvements diff --git a/uberjar/pom.xml b/uberjar/pom.xml index a0b3cfebb97..51cf4f6c4f2 100644 --- a/uberjar/pom.xml +++ b/uberjar/pom.xml @@ -200,6 +200,9 @@ io.fabric8:openshift-server-mock + + +