Skip to content
This repository has been archived by the owner on Jun 19, 2024. It is now read-only.

Rethink Route/Ingress generation #1374

Closed
rhuss opened this issue Sep 11, 2018 · 2 comments
Closed

Rethink Route/Ingress generation #1374

rhuss opened this issue Sep 11, 2018 · 2 comments
Assignees
Labels
jkube/pending The issue/PR has to be taken care of in JKube https://github.com/eclipse/jkube status/never-stale Pin this issue to get never marked as stale by stale-bot target/4.0 PR for targeted to 4.0.x

Comments

@rhuss
Copy link
Contributor

rhuss commented Sep 11, 2018

Description

Currently the configuration and generation of a Route/Ingress via automatic enrichment is a bit interwoven. For the target goal, to move all central logic into Maven independent parts (like enrichers), an option like fabric8.openshift.generateRoute=false which just filters out any routes during writing of the resource files, is problematic as a user might explicit´ly configure a route e.g. via a fragment might lead to conflicting situations.

Actually, every postprocessing of the generated resource files (like it happens also for converting Kubernetes to OpenShift objects) conflicts the way how the enrichment process is intended.

Ideally everything happens in the enrichers. So a good solution would be to move everything into RouteIngressEnricher and just disable this enricher if you don't want a route or ingress (which can be easily done with a profile, too).

Another issue with the current RouteEnricher is that it depends on the ExposeEnricher that a certain label gets added to a service which is picked up by the route enricher. Instead, the RouteEnricher should examine itself all service and should be able to configure to select the service to expose. This is much easier to understand, and makes the ExposeEnricher obsolete.

@rhuss rhuss added the target/4.0 PR for targeted to 4.0.x label Sep 11, 2018
@stale
Copy link

stale bot commented Dec 10, 2018

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

@stale stale bot added the status/stale Issue/PR considered to be stale label Dec 10, 2018
@rhuss rhuss removed the status/stale Issue/PR considered to be stale label Dec 11, 2018
@stale
Copy link

stale bot commented Mar 11, 2019

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

@stale stale bot added the status/stale Issue/PR considered to be stale label Mar 11, 2019
@rohanKanojia rohanKanojia added status/never-stale Pin this issue to get never marked as stale by stale-bot and removed status/stale Issue/PR considered to be stale labels Mar 11, 2019
@devang-gaur devang-gaur self-assigned this Jul 17, 2019
@devang-gaur devang-gaur added the jkube/pending The issue/PR has to be taken care of in JKube https://github.com/eclipse/jkube label Jul 24, 2019
@manusa manusa closed this as completed Jan 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
jkube/pending The issue/PR has to be taken care of in JKube https://github.com/eclipse/jkube status/never-stale Pin this issue to get never marked as stale by stale-bot target/4.0 PR for targeted to 4.0.x
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants