This repository has been archived by the owner on Jun 19, 2024. It is now read-only.
Rethink Route/Ingress generation #1374
Labels
jkube/pending
The issue/PR has to be taken care of in JKube https://github.com/eclipse/jkube
status/never-stale
Pin this issue to get never marked as stale by stale-bot
target/4.0
PR for targeted to 4.0.x
Description
Currently the configuration and generation of a Route/Ingress via automatic enrichment is a bit interwoven. For the target goal, to move all central logic into Maven independent parts (like enrichers), an option like
fabric8.openshift.generateRoute=false
which just filters out any routes during writing of the resource files, is problematic as a user might explicit´ly configure a route e.g. via a fragment might lead to conflicting situations.Actually, every postprocessing of the generated resource files (like it happens also for converting Kubernetes to OpenShift objects) conflicts the way how the enrichment process is intended.
Ideally everything happens in the enrichers. So a good solution would be to move everything into
RouteIngressEnricher
and just disable this enricher if you don't want a route or ingress (which can be easily done with a profile, too).Another issue with the current RouteEnricher is that it depends on the ExposeEnricher that a certain label gets added to a service which is picked up by the route enricher. Instead, the RouteEnricher should examine itself all service and should be able to configure to select the service to expose. This is much easier to understand, and makes the ExposeEnricher obsolete.
The text was updated successfully, but these errors were encountered: