Skip to content
This repository has been archived by the owner on Jun 19, 2024. It is now read-only.

Enhancement/Refactoring tasks for 'resource validation' : PR#1029 #1034

Closed
1 of 2 tasks
hrishin opened this issue Aug 31, 2017 · 1 comment
Closed
1 of 2 tasks

Enhancement/Refactoring tasks for 'resource validation' : PR#1029 #1034

hrishin opened this issue Aug 31, 2017 · 1 comment
Labels
cat/techdebt Technical debt, like missing unit tests or tests pr/help-wanted Please help with this PR status/stale Issue/PR considered to be stale

Comments

@hrishin
Copy link
Member

hrishin commented Aug 31, 2017

Following are improvements tasks has left from PR #1029 for issue #66

  • bundle JSON schema in maven package
  • sync and update JSON schema package

Problem:
PR #1029 has implemented JSON schema validation for verifying K8's/OpenShift resource descriptors.
JSON schema is hosted on github. Hence for each build cycle maven plugin issues the network calls (HTTP Request) that could make build process unreliable and increase network usage.

Solution:
-Bring essential JSON schema offline and bundle it in maven package as per discussion
-Cache schema file
-Other approach /solution? most welcome.

@hrishin hrishin added pr/help-wanted Please help with this PR Refactoring labels Aug 31, 2017
@hrishin hrishin changed the title Enhancement/Refactoring tasks for 'resource validation' : PR#1029 Issue#66 Enhancement/Refactoring tasks for 'resource validation' : PR#1029 Aug 31, 2017
@rhuss rhuss added cat/techdebt Technical debt, like missing unit tests or tests and removed cat/techdebt Technical debt, like missing unit tests or tests cat/refactoring labels Sep 14, 2018
@stale
Copy link

stale bot commented Dec 13, 2018

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

@stale stale bot added the status/stale Issue/PR considered to be stale label Dec 13, 2018
@stale stale bot closed this as completed Dec 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cat/techdebt Technical debt, like missing unit tests or tests pr/help-wanted Please help with this PR status/stale Issue/PR considered to be stale
Projects
None yet
Development

No branches or pull requests

2 participants