-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SaveMojo: Add docker.save.mode
option
#1219
Comments
It would be really great to be able to build docker image without the need of a Docker Daemon |
@radamanth that's a different discussion, though ;-) There will be eventually support for one way or another to create an image without a Docker daemon (which gets directly pushed to a Docker registry). In the meantime, you might want to have a look to https://github.com/GoogleContainerTools/jib which has a Maven plugin for doing exactly this. |
@radamanth As discussed in #1197 (comment) this change will allow to create the Dockerfile without the need for a Docker Daemon. |
@rhuss exactly ! |
@Beennnn so sorry and big apologies for this delay. I'm recently eaten up by other works (not even Java anymore these days) but will try now to move the PRs forward. |
I agree, that we can split up this issue in two: One for docker:save and one for docker:build. As docker:build is more important to you, I suggest to implement as described in #1197 (comment) and then move on to this issue. I for sure don't have the spare cycles to implement this feature, but I'm happy to help to integrate it (reviewing + merging). So if you feel fancy, please send a PR. |
Description
As result of the discussion in #1197 (comment) it would be good to have an option
docker.save.mode
with two possible values:docker:build
for sending it to the Docker daemon when creating an image.docker.save.file
should in both cases point to the target file name under which the archive should be created.The text was updated successfully, but these errors were encountered: