Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 4.2 compatability #6

Closed
besi opened this issue Mar 26, 2015 · 8 comments
Closed

Rails 4.2 compatability #6

besi opened this issue Mar 26, 2015 · 8 comments

Comments

@besi
Copy link

besi commented Mar 26, 2015

I want to update my project from Rails 4.1 to Rails 4.2.

The globalize Readme states:

When using bundler put this in your Gemfile:

gem 'globalize', '~> 5.0.0'

To use the version of globalize for ActiveRecord 4.0 or 4.1, specify:

gem 'globalize', '~> 4.0.3'

So I also updated the globalize gem from 4 to 5. However when I do this I get a dependency error:

$ bundle update activeadmin-globalize globalize
Updating git://github.com/fabn/activeadmin-globalize.git
Fetching gem metadata from https://rails-assets.org/...
Fetching gem metadata from https://rubygems.org/.........
Fetching additional metadata from https://rubygems.org/..
Resolving dependencies...
Bundler could not find compatible versions for gem "globalize":
  In Gemfile:
    activeadmin-globalize (~> 1.0.0.pre) ruby depends on
      globalize (~> 4.0) ruby

    globalize (5.0.0)

Is there generally a way to get activeadmin-globalize to work with rails 4.2

@fabn
Copy link
Owner

fabn commented Mar 26, 2015

Not yet. I will work on this on the next few days and I will use a travis build matrix in specs to ensure it's working on all released rails versions.

@besi
Copy link
Author

besi commented Mar 26, 2015

👍 Thanks for the heads up

@micred
Copy link

micred commented Apr 27, 2015

Hi @fabn are there any progress in Rails 4.2 compatibility? I will happy to test a dev branch if you like.
Thank you

@NickClark
Copy link

Status update on the Rails 4.2 support?

@fabn fabn closed this as completed in f02fc8d Jul 9, 2015
@fabn
Copy link
Owner

fabn commented Jul 9, 2015

I relaxed dependencies to work with rails 4.2. Now you should be able to install this gem in rails 4.2 using the develop branch.

@besi
Copy link
Author

besi commented Aug 29, 2016

@fabn Is Rails 5 already on the roadmap?

@fabn
Copy link
Owner

fabn commented Aug 30, 2016

@besi not yet. I'm pretty busy with work in this period and I don't know when I'll be able to handle that.

Meanwhile if you want to sketch a PR it would be very welcome 😉

@besi
Copy link
Author

besi commented Oct 2, 2017

Actually the develop branch seems to be working fine:

screen shot 2017-10-02 at 13 54 21

screen shot 2017-10-02 at 13 53 52

This is an excerpt from my Gemfile:

I'm using ruby 2.4.1.p111

gem 'rails', '~> 5.1.4'
gem 'activeadmin'
gem 'activeadmin-sortable'
gem 'globalize', git: 'https://github.com/globalize/globalize', branch: 'master'
gem 'activemodel-serializers-xml'
gem 'activeadmin-globalize', github: 'fabn/activeadmin-globalize', branch: 'develop'
gem 'globalize-versioning', github: 'besi/globalize-versioning', branch: 'patch-1'

Sidenote: I am using the globalize-versioning which isn't fully compatible yet. See this issue globalize/globalize-versioning#14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants