Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Witnesses #2104

Closed
alfonsogarciacaro opened this issue Jun 23, 2020 · 2 comments · Fixed by #2240
Closed

Witnesses #2104

alfonsogarciacaro opened this issue Jun 23, 2020 · 2 comments · Fixed by #2240

Comments

@alfonsogarciacaro
Copy link
Member

Related #2101 #2083

SRTP resolution in Fable is not good and fails many times as in the issues reported above. This is because the F# TypedTree didn't expose much information and Fable had to make its own rudimentary resolution.

Fortunately this is about to change thanks to Don Syme work to include witnesses for SRTP resolution in the TypedTree and expose them in the FCS API: dotnet/fsharp#9510

Use the new FCS to take advantage of the witnesses and use the same STRP resolution as the F# compiler does.

@gusty
Copy link
Contributor

gusty commented Sep 12, 2020

Could this be related to #2135 ?

I am not sure as the SRTP call involved there is a simple one (no multiple type variables involved).

@alfonsogarciacaro
Copy link
Member Author

Sorry @gusty, I just realized I missed #2135. Still get confused with the new UI for notifications 🤦

Yes, definitely. When we can use the new witness feature we can let FCS handle SRTP, and remove Fable's custom (and buggy) resolution mechanism.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants