Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for server 2016 #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update for server 2016 #1

wants to merge 1 commit into from

Conversation

SDBrett
Copy link

@SDBrett SDBrett commented Mar 30, 2023

Changes to script based on testing with Windows Server 2016 and Windows 10.

  • Update Readme to provide additional clarity about how the script and first boot function
  • Update to version 1.1
  • Line 91: Resolve error: msft_netipaddress already exists
  • Line 129: Correct expression for drives with no drive letter
  • Line 148 - Line 164: Change to get-wmiobject for consistency with following lines and refactor
  • Line 149: Add device type to filter out drivers other than local disk
  • Lines 153 - 155: Filter out system drive from drive letter assignment as driver is assigned by default

fabiendupont
fabiendupont approved these changes Mar 31, 2023
View reviewed changes
Copy link
Owner

@fabiendupont fabiendupont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typos. Otherwise looks good. Thanks.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@fabiendupont
Update for server 2016
fdd7f63 
Co-authored-by: Fabien Dupont <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiendupont fabiendupont fabiendupont approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SDBrett @fabiendupont