Conversion of TCP profile failing using vscode ACC Chariot extension

[ajgerace]

Environment

• F5 Extension version: v3.1.0
• F5 ACC Chariot version: v1.13.0

Summary

Attempting to convert a TCP profile using the VScode F5 Extension with the ACC Chariot extension fails to convert and throws an error and nothing is converted

Steps To Reproduce

Steps to reproduce the behavior:

1. Convert following config snippet:

ltm profile tcp mytcp-progressive {
    app-service none
    auto-proxy-buffer-size enabled
    auto-receive-window-size enabled
    auto-send-buffer-size enabled
    congestion-control woodside
    defaults-from tcp
    init-cwnd 16
    init-rwnd 16
    nagle auto
    proxy-buffer-high 262144
    proxy-buffer-low 196608
    push-flag auto
    receive-window-size 131072
    send-buffer-size 262144
}

2. Observe the following error message:

[2021-08-25T21:29:38.352Z] [INFO]: f5.chariot.convert text found
[2021-08-25T21:29:38.353Z] [ERROR]: f5.chariot.convert failed with [TypeError: Cannot read property 'endsWith' of undefined
	at module.exports (/Users/gerace/.vscode/extensions/f5devcentral.vscode-f5-chariot-1.13.0/node_modules/f5-as3-config-converter/src/util/convert/findLocation.js:33:24)
	at module.exports (/Users/gerace/.vscode/extensions/f5devcentral.vscode-f5-chariot-1.13.0/node_modules/f5-as3-config-converter/src/removeIapp.js:27:21)
	at mainRunner (/Users/gerace/.vscode/extensions/f5devcentral.vscode-f5-chariot-1.13.0/node_modules/f5-as3-config-converter/src/main.js:50:28)
	at Object.mainAPI (/Users/gerace/.vscode/extensions/f5devcentral.vscode-f5-chariot-1.13.0/node_modules/f5-as3-config-converter/src/main.js:175:30)
	at /Users/gerace/.vscode/extensions/f5devcentral.vscode-f5-chariot-1.13.0/out/extension.js:76:62
	at processTicksAndRejections (internal/process/task_queues.js:93:5)
	at async /Users/gerace/.vscode/extensions/f5devcentral.vscode-f5-chariot-1.13.0/out/extension.js:67:20]

Expected Behavior

An AS3 declaration with the TCP profile is to be created.

Actual Behavior

Nothing is outputted and an error occurs in output window.

[ajgerace]

Upon further investigation, the standard TCP profile also fails to successfully convert.

ltm profile tcp tcp {
    abc enabled
    ack-on-push enabled
    app-service none
    auto-proxy-buffer-size disabled
    auto-receive-window-size disabled
    auto-send-buffer-size disabled
    close-wait-timeout 5
    cmetrics-cache enabled
    cmetrics-cache-timeout 0
    congestion-control high-speed
    deferred-accept disabled
    delay-window-control disabled
    delayed-acks enabled
    dsack disabled
    early-retransmit enabled
    ecn enabled
    enhanced-loss-recovery enabled
    fast-open enabled
    fast-open-cookie-expiration 21600
    fin-wait-2-timeout 300
    fin-wait-timeout 5
    idle-timeout 300
    init-cwnd 10
    init-rwnd 10
    ip-tos-to-client 0
    keep-alive-interval 1800
    limited-transmit enabled
    link-qos-to-client 0
    max-retrans 8
    max-segment-size 1460
    md5-signature disabled
    minimum-rto 1000
    mptcp disabled
    nagle disabled
    pkt-loss-ignore-burst 0
    pkt-loss-ignore-rate 0
    proxy-buffer-high 65535
    proxy-buffer-low 32768
    proxy-mss enabled
    proxy-options disabled
    push-flag default
    rate-pace enabled
    rate-pace-max-rate 0
    receive-window-size 65535
    reset-on-timeout enabled
    rexmt-thresh 3
    selective-acks enabled
    selective-nack disabled
    send-buffer-size 131072
    slow-start enabled
    syn-cookie-enable enabled
    syn-cookie-whitelist disabled
    syn-max-retrans 3
    syn-rto-base 3000
    tail-loss-probe enabled
    time-wait-recycle enabled
    time-wait-timeout 2000
    timestamps enabled
    verified-accept disabled
    zero-window-timeout 20000
}

Ironically another tcp profile from the same device does convert

ltm profile tcp /Common/tcp_lan {
    abc enabled
    ack-on-push enabled
    app-service none
    auto-proxy-buffer-size enabled
    auto-receive-window-size enabled
    auto-send-buffer-size enabled
    close-wait-timeout 5
    cmetrics-cache enabled
    cmetrics-cache-timeout 0
    congestion-control woodside
    deferred-accept disabled
    delay-window-control disabled
    delayed-acks enabled
    description none
    dsack disabled
    early-retransmit enabled
    ecn enabled
    enhanced-loss-recovery enabled
    fast-open enabled
    fast-open-cookie-expiration 21600
    fin-wait-2-timeout 300
    fin-wait-timeout 5
    idle-timeout 300
    init-cwnd 16
    init-rwnd 16
    ip-df-mode pmtu
    ip-tos-to-client 0
    ip-ttl-mode proxy
    ip-ttl-v4 255
    ip-ttl-v6 64
    keep-alive-interval 1800
    limited-transmit enabled
    link-qos-to-client 0
    max-retrans 8
    max-segment-size 0
    md5-signature disabled
    minimum-rto 1000
    mptcp disabled
    mptcp-csum disabled
    mptcp-csum-verify disabled
    mptcp-fallback reset
    mptcp-fastjoin disabled
    mptcp-idle-timeout 300
    mptcp-join-max 5
    mptcp-makeafterbreak disabled
    mptcp-nojoindssack disabled
    mptcp-rtomax 5
    mptcp-rxmitmin 1000
    mptcp-subflowmax 6
    mptcp-timeout 3600
    nagle auto
    pkt-loss-ignore-burst 0
    pkt-loss-ignore-rate 0
    proxy-buffer-high 262144
    proxy-buffer-low 196608
    proxy-mss enabled
    proxy-options disabled
    push-flag auto
    rate-pace enabled
    rate-pace-max-rate 0
    receive-window-size 131072
    reset-on-timeout enabled
    rexmt-thresh 3
    selective-acks enabled
    selective-nack disabled
    send-buffer-size 262144
    slow-start enabled
    syn-cookie-enable enabled
    syn-cookie-whitelist disabled
    syn-max-retrans 3
    syn-rto-base 3000
    tail-loss-probe enabled
    tcp-options none
    time-wait-recycle enabled
    time-wait-timeout 2000
    timestamps enabled
    verified-accept disabled
    zero-window-timeout 20000
}

[mdditt2000]

Create Jira CHARON-433 for PM tracking. Recreate https://github.com/mdditt2000/f5-appsvcs-acc/tree/master/Github/49

[mdditt2000]

@ajgerace thanks for opening this issue. Ping me via Teams with the priority.

[mdditt2000]

Merge branch 'CHARON-433-location-bug' into 'develop'. --- Resolved