Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clientCertificate should be string instead of list #38

Closed
makagonr opened this issue Jun 15, 2021 · 3 comments
Closed

clientCertificate should be string instead of list #38

makagonr opened this issue Jun 15, 2021 · 3 comments
Labels
bug Something isn't working jira Jira created for this issue
Milestone

Comments

@makagonr
Copy link

Environment

ACC 1.12

Summary

According to AS3 schema, inside "TLS_Client" class, field "clientCertificate" should be string, but 1.12 ACC produces a list of strings.

Take a look at field "clientCertificate" under this link:
https://clouddocs.f5.com/products/extensions/f5-appsvcs-extension/latest/refguide/schema-reference.html?highlight=tls_client#tls-client

Steps To Reproduce

Try to convert the following config:
bigip.conf.txt

Actual Behavior

...
                "custom_ssl_server_profile": {
                    "clientCertificate": [
                        "custom_ssl_cert_key"
                    ],  
                    "ciphers": "DEFAULT",
                    "class": "TLS_Client"
                },  
...

Expected Behavior

...
                "custom_ssl_server_profile": {
                    "clientCertificate": "custom_ssl_cert_key",
                    "ciphers": "DEFAULT",
                    "class": "TLS_Client"
                }, 
...

@makagonr makagonr added the bug Something isn't working label Jun 15, 2021
@mdditt2000 mdditt2000 added the PME PME Action Item label Jun 29, 2021
@mdditt2000
Copy link

Output

            "custom_ssl_server_profile": {
                "alertTimeout": "indefinite",
                "cacheTimeout": 3600,
                "clientCertificate": [ -------------- Not a valid string
                    "custom_ssl_cert_key"
                ],
                "ciphers": "DEFAULT",
                "renegotiationEnabled": true,
                "sendSNI": "none",
                "sessionTickets": false,
                "forwardProxyEnabled": false,
                "forwardProxyBypassEnabled": false,
                "class": "TLS_Client",
                "tls1_0Enabled": true,
                "tls1_1Enabled": true,
                "tls1_2Enabled": true,
                "tls1_3Enabled": false,
                "singleUseDhEnabled": false,
                "insertEmptyFragmentsEnabled": false
            },

Line 24 https://github.com/mdditt2000/f5-appsvcs-acc/blob/master/Github/38/as3-convert.json

Creating Jira

@mdditt2000
Copy link

Created CHARON-400 for PM tracking.

@mdditt2000 mdditt2000 added jira Jira created for this issue and removed PME PME Action Item labels Jul 26, 2021
@mdditt2000
Copy link

Found bug in found a bug in loadCertsAndKeys. Issue resolved

@mdditt2000 mdditt2000 added this to the 1.15 milestone Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working jira Jira created for this issue
Projects
None yet
Development

No branches or pull requests

2 participants