Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complex numbers support #19

Closed
pierreguilmin opened this issue Dec 6, 2024 · 1 comment · Fixed by #20
Closed

Complex numbers support #19

pierreguilmin opened this issue Dec 6, 2024 · 1 comment · Fixed by #20

Comments

@pierreguilmin
Copy link

Thanks a lot for your excellent library! 👏

When integrating a complex-valued function, for example just just changing the README example to fun = lambda t: t * jnp.log(1 + t) * 1j, I get a TypeError:

TypeError: true_fun and false_fun output must have identical types, got
('ShapedArray(complex64[])', 'ShapedArray(float32[], weak_type=True)', 'DIFFERENT ShapedArray(complex64[]) vs. ShapedArray(float32[])', 'DIFFERENT ShapedArray(complex64[]) vs. ShapedArray(float32[])').

This happens even when the norm is real-valued (which is the default anyway I think).

@f0uriest
Copy link
Owner

f0uriest commented Dec 7, 2024

Thanks, this was due to some type mismatches when shortcutting a zero length interval. Should be fixed by #20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants