Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-32320: Fixed image placeholders generation on DFS #3086

Merged
merged 2 commits into from
Feb 26, 2021
Merged

EZP-32320: Fixed image placeholders generation on DFS #3086

merged 2 commits into from
Feb 26, 2021

Conversation

adamwojs
Copy link
Member

@adamwojs adamwojs commented Feb 9, 2021 •
edited
Loading

Question Answer
JIRA issue EZP-32320
Bug/Improvement yes
New feature no
Target version 7.5
BC breaks no
Tests pass yes
Doc needed yes

Added verify_binary_data_availability configuration option to enable additional binary data availability check in \eZ\Bundle\EzPublishCoreBundle\Imagine\PlaceholderAliasGenerator in order to detect missing images. By default binary data availability check is disabled to avoid additional IO operations.

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@adamwojs adamwojs changed the title EZP-32320: Fixed image placeholders generation on DFS [WIP] EZP-32320: Fixed image placeholders generation on DFS Feb 10, 2021
@adamwojs adamwojs force-pushed the ezp_32320 branch 2 times, most recently from 11d5ae3 to d3f6d9a Compare February 15, 2021 08:36
@adamwojs adamwojs self-assigned this Feb 15, 2021
@adamwojs adamwojs added the Bug label Feb 15, 2021
@adamwojs adamwojs changed the title [WIP] EZP-32320: Fixed image placeholders generation on DFS EZP-32320: Fixed image placeholders generation on DFS Feb 15, 2021
@adamwojs adamwojs requested a review from a team February 15, 2021 10:53
@adamwojs adamwojs requested a review from a team February 22, 2021 12:53
Steveb-p
Steveb-p approved these changes Feb 22, 2021
View reviewed changes
Copy link
Contributor

@Steveb-p Steveb-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomaszszopinski tomaszszopinski self-assigned this Feb 23, 2021
tomaszszopinski
tomaszszopinski approved these changes Feb 26, 2021
View reviewed changes
Copy link

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on ezplat-ee 2.5 & Ibexa dxp 3.2.4 & 3.3.1-dev with diff & patch.

@lserwatka lserwatka merged commit 45d8f1f into 7.5 Feb 26, 2021
@lserwatka lserwatka deleted the ezp_32320 branch February 26, 2021 09:36
@lserwatka
Copy link
Member

Could you merge it up?

This was referenced Mar 11, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Steveb-p Steveb-p Steveb-p approved these changes

@alongosz alongosz alongosz approved these changes

@ViniTou ViniTou ViniTou approved these changes

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

Assignees

@adamwojs adamwojs

@tomaszszopinski tomaszszopinski

Labels
Bug QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@adamwojs @lserwatka @Steveb-p @alongosz @ViniTou @tomaszszopinski