EZP-32308: Fixed evaluating permissions on non prepared targets

[ViniTou]

Question	Answer
JIRA issue	EZP-32308
Bug/Improvement	yes
New feature	no
Target version	7.5
BC breaks	no
Tests pass	yes
Doc needed	no

Instead of requiring that all targets must be instance of Location, at least one valid is needed.

TODO:

• Implement feature / fix a bug.
• Implement tests.
• Fix new code according to Coding Standards ($ composer fix-cs).
• Ask for Code Review.

[alongosz]

1. It's a bit unclear to me what is present in $targets which causes the issue. Based on the description there should be no such issue, on the contrary - only Location should be present
2. This requires integration test coverage (we already have similar tests).
3. Commit message & PR title needs to be rephrased to follow the conventions.

[ViniTou]

It's a bit unclear to me what is present in $targets which causes the issue. Based on the description there should be no such issue, on the contrary - only Location should be present.

Only \eZ\Publish\SPI\Limitation\Target\Version was provided inside adminUI checks.

[Nattfarinn]

I'm confused. Location limitation is probably one of the most used limitations in the system. How did it not explode earlier? Is it really the very first occurrence of mixed $targets (which could be pretty common actually)?

[ViniTou]

@Nattfarinn

Is it really the very first occurrence of mixed $targets (which could be pretty common actually)?

No it is not, and all other places were systematically patched up and fixed (@mikadamczyk).
You may even see that same logic below in that same class
https://github.com/ezsystems/ezpublish-kernel/pull/3083/files#diff-a2d05e3e6c6fceef94a01e793d3e02b31b4d8d320f0535181fc5855c8db43f85R178

Why it came from clients now and not long time ago? 🤷 But it is with us since 2.5.1

[mikadamczyk]

I'm not sure if this limitation change should actually be removed. From what I can see in PR EZP-30344: Allowed limiting Content management to specific translations (# 2585) then when adding the method prepareTargetsForType to PermissionResolver https://github.com/ezsystems/ezpublish-kernel/pull/2585/files#diff-0f692381531f1f40b194e997c1e98f1c72bd6ca3f97de35274be3cfeca8d5e6fR424 was added https://github.com/ezsystems/ezpublish-kernel/pull/2585/files#diff-23d89diff-23d89diff-23d89diffed965cf6b531diff-23d89diffed965c

For me, if we allow the possibility that Limitation can get different targets, then it should not throw this exception. Because in every place (old and new) you will need to know/remember that before doing LimitationType::evaluate you have to filter the targets

So both commit should be added

[tomaszszopinski]

QA approved on eZPlatform 2.5 & v2.5.16 with patch & diff.

[adamwojs]

Could you please merge up changes @ViniTou?