-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EZP-32308: Fixed evaluating permissions on non prepared targets #3083
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- It's a bit unclear to me what is present in
$targets
which causes the issue. Based on the description there should be no such issue, on the contrary - only Location should be present - This requires integration test coverage (we already have similar tests).
- Commit message & PR title needs to be rephrased to follow the conventions.
Only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused. Location limitation is probably one of the most used limitations in the system. How did it not explode earlier? Is it really the very first occurrence of mixed $target
s (which could be pretty common actually)?
No it is not, and all other places were systematically patched up and fixed (@mikadamczyk). Why it came from clients now and not long time ago? 🤷 But it is with us since 2.5.1 |
I'm not sure if this limitation change should actually be removed. From what I can see in PR For me, if we allow the possibility that Limitation can get different targets, then it should not throw this exception. Because in every place (old and new) you will need to know/remember that before doing LimitationType::evaluate you have to filter the targets So both commit should be added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA approved on eZPlatform 2.5 & v2.5.16 with patch & diff.
Could you please merge up changes @ViniTou? |
7.5
Instead of requiring that all
targets
must be instance ofLocation
, at least one valid is needed.TODO:
$ composer fix-cs
).