Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input parameter validation #4

Open
5 tasks
ezpzbz opened this issue Mar 13, 2020 · 1 comment
Open
5 tasks

Input parameter validation #4

ezpzbz opened this issue Mar 13, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@ezpzbz
Copy link
Owner

ezpzbz commented Mar 13, 2020

We need to add validation of input parameters. It can be implemented based on discussion in AiiDA Hackathon by defining a new Data class.
This will be done once the calculation and parser are well tested.
[UPDATE] Currently, I am working on having this validation on functional and basis set by:

  • Having separate inputs for them instead passing them in parameters dictionary
  • I need a list of supported functionals by ORCA as well as its Libxc interface.
  • User provided functional would be checked against valid values and gets verified.
  • In the case of basis sets, same story applies for the ORCA internal basis sets.
  • In the case of basis sets, we can have a degree of automation to set proper flags if user requests RI, RICOSX, and RIJK approximations.
@ezpzbz ezpzbz added enhancement New feature or request help wanted Extra attention is needed labels Mar 13, 2020
@ezpzbz ezpzbz added this to the v0.3.0 milestone Mar 13, 2020
@ezpzbz ezpzbz self-assigned this Mar 13, 2020
@ezpzbz ezpzbz modified the milestones: v0.3.0, v1.0.0 Mar 14, 2020
@ezpzbz ezpzbz removed the help wanted Extra attention is needed label May 27, 2021
@danielhollas
Copy link
Collaborator

I am not sure if this is a good idea in general, it seems to me it would take a too much maintenance, and different ORCA versions may support different functionals and basis sets.

It would be great if ORCA provided a 'dry-run' option or some kind of input checker, but it doesn't seem to be the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants