tsconfigOverride options do not override default config options -- missing compilerOptions

[kettanaito]

Hi. Thank you for a great rollup plugin!

What happens and why it is wrong

I need to specify declaration: false flag for the entire rollup processing pipeline. This should prevent type declarations from being generated (expected behavior). My tsconfig (see attached below) has declarations: true on purpose, since I use it with ttsc command to generate type definitions as a separate step.

Since this plugin uses the tsconfig.json I wanted to override the default config's options (see rollup setup below) using the tsconfigOverride option. However, it doesn't seem to override the default option value, and type definitions are still emitted.

Versions

• typescript: 3.2.2
• rollup: 1.10.1
• rollup-plugin-typescript2: 0.21.0

rollup.config.js

import ttypescript from 'ttypescript'
import tsPlugin from 'rollup-plugin-typescript2'
// ...other imports are irrelevant

const typescript = () => {
  return tsPlugin({
    clean: true,
    // Disable type checking during the build
    // to increase the build speed. Types must be
    // checked during the local development.
    // They may also be checked during type definition
    // emitting (ttsc)
    check: false,
    tsconfigOverride: {
      declaration: false,
    },
    // Provide custom TypeScript instance so it can
    // resolve path aliases (i.e. "@utils/").
    typescript: ttypescript,
  })
}

const buildCjs = () => ({
  input,
  external,
  output: {
    file: getPath(packageJson.main),
    format: 'cjs',
    exports: 'named',
    sourcemap: PRODUCTION,
  },
  plugins: [
    resolve(),
    typescript(),
    replace({
      __PROD__,
      'process.env.NODE_ENV': JSON.stringify(nodeEnv),
    }),
    PRODUCTION && sourceMaps(),
    PRODUCTION &&
      terser({
        ecma: 5,
        sourcemap: true,
        output: {
          comments: false,
        },
        warnings: true,
        toplevel: true,
      }),
  ],
})

tsconfig.json

{
  "compileOnSave": true,
  "compilerOptions": {
    "types": ["jest"],
    "module": "es6",
    "target": "esnext",
    "moduleResolution": "node",
    "outDir": "types",
    "declaration": true,
    "noImplicitThis": false,
    "esModuleInterop": true,
    "jsx": "react",
    "baseUrl": ".",
    "paths": {
      "@src/*": ["src/*"],
      "@components/*": ["src/components/*"],
      "@const/*": ["src/const/*"],
      "@utils/*": ["src/utils/*"]
    },
    "plugins": [
      {
        "transform": "@zerollup/ts-transform-paths"
      }
    ]
  },
  "include": ["src"],
  "exclude": ["node_modules", "**/*.spec.ts"]
}

---

I would be thankful for any feedback on this issue.

[kettanaito]

My apologies. I have overlooked the compilerOptions nested key. Including the proper nesting solves the issue:

// rollup.config.js
const typescript = () => {
  return tsPlugin({
    clean: true,
    // Disable type checking during the build
    // to increase the build speed. Types must be
    // checked during the local development.
    // They may also be checked during type definition
    // emitting (ttsc)
    check: false,
    tsconfigOverride: {
      compilerOptions: {
        declaration: false,
      },
    },
    // Provide custom TypeScript instance so it can
    // resolve path aliases (i.e. "@utils/").
    typescript: ttypescript,
  })
}

Thank you once more for the great work!