Skip to content

Commit

Permalink
Fix macOS release CI
Browse files Browse the repository at this point in the history
Since the CI machine is amd64, it is not possible to just execute the
aarch64 binary to test the application. So instead of running `cargo
test`, we just use `cargo build` instead.

Building on the non-release CI instead of just checking also allows us
to make sure linking works properly before a release fails due to it.
  • Loading branch information
chrisduerr authored Jan 13, 2022
1 parent 1c9fa73 commit 7398e9f
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,5 +31,5 @@ jobs:
- uses: actions/checkout@v2
- name: Install target
run: rustup update && rustup target add aarch64-apple-darwin
- name: Check build
run: cargo check --target=aarch64-apple-darwin
- name: Build
run: cargo build --target=aarch64-apple-darwin
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ jobs:
run: rustup update && rustup target add aarch64-apple-darwin
- name: Test
run: cargo test --release
- name: Test ARM
run: cargo test --release --target=aarch64-apple-darwin
- name: Build ARM
run: cargo build --release --target=aarch64-apple-darwin
- name: Make DMG
run: make dmg-universal
- name: Upload Application
Expand Down

0 comments on commit 7398e9f

Please sign in to comment.