Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove google_auth_client_secret from docker compose #954

Open
MelchiorKokernoot opened this issue Sep 5, 2024 · 0 comments
Open

Remove google_auth_client_secret from docker compose #954

MelchiorKokernoot opened this issue Sep 5, 2024 · 0 comments

Comments

@MelchiorKokernoot
Copy link
Contributor

https://github.com/eyra/mono/blob/master/docker-compose.yml#L28

Shows the google_auth_client_secret, although this secret is (at a glance) not used anywhere, this secret should not be publicly visible and should be deleted from the current version.

Scope
For now, it is not required to remove the secret from the entire VCS history, Melle implied that more of these "should permanently deleted" parts exist. These should be identified and permanently deleted in batch, which will follow from a new issue

@MelchiorKokernoot MelchiorKokernoot converted this from a draft issue Sep 5, 2024
@MelchiorKokernoot MelchiorKokernoot moved this to Backlog in Maintenance #1 Sep 5, 2024
@MelchiorKokernoot MelchiorKokernoot moved this from Backlog to Ready in Maintenance #1 Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready
Development

No branches or pull requests

1 participant