Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync and async versions of copy_single disagree - pointers vs references #687

Open
eyalroz opened this issue Oct 19, 2024 · 0 comments
Open

Comments

@eyalroz
Copy link
Owner

eyalroz commented Oct 19, 2024

We currently have:

template <typename T>
void copy_single(T* destination, const T* source)

in cuda::memory, but:

void copy_single(T& destination, const T& source, const stream_t& stream);

i cuda::memory::async. We should either have references in both signatures or in none.

@eyalroz eyalroz added the task label Oct 19, 2024
eyalroz added a commit that referenced this issue Oct 20, 2024
eyalroz added a commit that referenced this issue Oct 20, 2024
eyalroz added a commit that referenced this issue Oct 26, 2024
eyalroz added a commit that referenced this issue Oct 26, 2024
eyalroz added a commit that referenced this issue Oct 28, 2024
eyalroz added a commit that referenced this issue Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant