Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poor man's optional const&& constructor causes trouble in some cases #666

Open
eyalroz opened this issue Aug 21, 2024 · 0 comments
Open
Labels
ms-windows Related to the Microsoft Windows operating system resolved-on-development

Comments

@eyalroz
Copy link
Owner

eyalroz commented Aug 21, 2024

Trouble building with MSVC was reported in #664 , and the cause seems to be a gratuituous constructor of "poor man's optional":

poor_mans_optional &operator=(const T &&value) noexcept(::std::is_nothrow_move_assignable<T>::value)

I'm not quite sure why I introduced this in the first place, given that we already have a

poor_mans_optional &operator=(T &&value) noexcept(::std::is_nothrow_move_assignable<T>::value)

... so let's just remove this.

@eyalroz eyalroz added the ms-windows Related to the Microsoft Windows operating system label Aug 21, 2024
eyalroz added a commit that referenced this issue Aug 21, 2024
…of `poor_mans_optional<T>` from `const T&&`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ms-windows Related to the Microsoft Windows operating system resolved-on-development
Projects
None yet
Development

No branches or pull requests

1 participant