Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typed_set mistakenly accepts values of size 8 #517

Closed
eyalroz opened this issue May 17, 2023 · 1 comment
Closed

typed_set mistakenly accepts values of size 8 #517

eyalroz opened this issue May 17, 2023 · 1 comment
Assignees
@eyalroz
Labels
bug resolved-on-development

Comments

@eyalroz
Copy link
Owner

eyalroz commented May 17, 2023

The cuda::memory::device::typed_set function template is only supposed to accept elements of a size which has a cuMemsetDXX() function, for XX being the size in bits of the type. That means sizes of 1, 2 and 4. But - we mistakenly currently accept inputs of size 8, and don't handle them at all.
@eyalroz eyalroz added the bug label May 17, 2023
@eyalroz eyalroz self-assigned this May 17, 2023
@eyalroz
Copy link
Owner Author

eyalroz commented May 17, 2023

Fixed in commit 9cb0f2a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyalroz eyalroz

Labels
bug resolved-on-development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz