Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Size checks in one of the array copy function is reversed #428

Closed
eyalroz opened this issue Oct 14, 2022 · 0 comments
Closed

Size checks in one of the array copy function is reversed #428

eyalroz opened this issue Oct 14, 2022 · 0 comments
Assignees
@eyalroz
Labels
bug

Comments

@eyalroz
Copy link
Owner

eyalroz commented Oct 14, 2022

In:

template <typename T, dimensionality_t NumDimensions>
void copy(region_t destination, const array_t<T, NumDimensions>& source)

the size check is currently wrong: We're failing if the source is smaller than the destination rather than the other way around.
@eyalroz eyalroz added the bug label Oct 14, 2022
@eyalroz eyalroz self-assigned this Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyalroz eyalroz

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz