-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move wrap() methods for significant wrapper classes out of detail_::
#298
Comments
The relevant function is, indeed, in the |
I do not have a reference for that, but intuitively this is what I expect from a detail/internal namespace. This enables also changes within the detail namespace of the library without breaking user code. |
@codecircuit : Well, if you interact with CUDA through the wrappers, you won't need to wrap any handles. But it's true that if you mix API wrappers code with other CUDA-related code, then you might. So I guess I can take the |
detail_
namespace?detail_::
@codecircuit : Please give v0.4.5-rc2 a spin... |
Wait a minute though. Do you think that the function for wrapping a stream handle should be all-low-level? i.e. take the device handle? Or should it take a device_t? And similarly, when wrapping something with more context, e.g. both a CUDA device, and a CUDA context for a driver-API stream - should I also take the lower-level handles or the device_t and the context_t? In the non- |
I might not found it, but there seems no way to construct a non-owning
cuda::stream_t
object from a nativecudaStream_t
without using a function from thedetail_
namespace. I think this would be useful to improve the interoperability with other libraries. We could add a usage example in stream_management.cu.The text was updated successfully, but these errors were encountered: