Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YouTube playlist url doesn't work #97

Closed
NickBlow opened this issue Oct 20, 2021 · 3 comments
Closed

YouTube playlist url doesn't work #97

NickBlow opened this issue Oct 20, 2021 · 3 comments

Comments

@NickBlow
Copy link
Contributor

The generated Regex for the url is https:\/\/(.*).youtube.com\/playlist?list=(.*). Unfortunately, it needs to match the ? character literally as this is a regex reserved character.
@NickBlow
Copy link
Contributor Author

https://github.com/ndaidong/oembed-parser/pull/98/files should fix this issue

@ndaidong ndaidong mentioned this issue Oct 22, 2021
Merged
@ndaidong
Copy link
Collaborator

ndaidong commented Oct 22, 2021 •
edited
Loading

@NickBlow I've merged your pr and published v1.4.9
Please check if your issue has been resolved.

@NickBlow
Copy link
Contributor Author

Resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ndaidong @NickBlow