-
Notifications
You must be signed in to change notification settings - Fork 404
Add optional deployment labels value to charts #814
Add optional deployment labels value to charts #814
Conversation
@Flydiverny can you please give this failing check a look? Seems the e2e test build is breaking. I am based off the the latest master branch, and my changes shouldn't have affected this I wouldn't think:
|
@Flydiverny any status on this e2e failure, or any way for me to re-run the build? Also thanks for the quick responses so far, much appreciated :-) Edit: Tried to rebase and reword to push the same commit to trigger rebuild, did not work. Seems rebuild will need to be done manually by an admin |
a bit confused why the builds are failing. Seems like the same error was silently failing in the docker build as well, some optional dependency. Not sure why E2E would fail tho, dockerfiles are close to identical 😅 Trying to address the dependency in question in #818 |
Right! Solved in #819, underlying issue being use of deprecated kubectl flags and the kubectl version was updated in the runner (which is just using ubuntu-latest, so guess it got updated recently with new releases). Should work if you can rebase :) |
@Flydiverny rebased off of upstream master, should be good to run! I do need your help to click the buttons though since I'm a first time contributor:
|
Cheers! Released in 8.3.0 |
Have a use case where we want to add labels to the deployments, but were currently unable to do so with the charts. Adding this optional value