Skip to content
This repository has been archived by the owner on Jul 26, 2022. It is now read-only.

Add optional deployment labels value to charts #814

Merged
merged 1 commit into from
Aug 5, 2021
Merged

Add optional deployment labels value to charts #814

merged 1 commit into from
Aug 5, 2021

Conversation

jweilhammer
Copy link
Contributor

Have a use case where we want to add labels to the deployments, but were currently unable to do so with the charts. Adding this optional value

@jweilhammer jweilhammer marked this pull request as ready for review August 4, 2021 14:32
@jweilhammer
Copy link
Contributor Author

@Flydiverny can you please give this failing check a look?

Seems the e2e test build is breaking. I am based off the the latest master branch, and my changes shouldn't have affected this I wouldn't think:

gyp ERR! find Python
gyp ERR! find Python Python is not set from command line or npm configuration
gyp ERR! find Python Python is not set from environment variable PYTHON
gyp ERR! find Python checking if "python" can be used
gyp ERR! find Python - "python" is not in PATH or produced an error
gyp ERR! find Python checking if "python2" can be used
gyp ERR! find Python - "python2" is not in PATH or produced an error
gyp ERR! find Python checking if "python3" can be used
gyp ERR! find Python - "python3" is not in PATH or produced an error
gyp ERR! find Python
gyp ERR! find Python **********************************************************
gyp ERR! find Python You need to install the latest version of Python.
gyp ERR! find Python Node-gyp should be able to find and use Python. If not,
gyp ERR! find Python you can try one of the following options:
gyp ERR! find Python - Use the switch --python="/path/to/pythonexecutable"
gyp ERR! find Python   (accepted by both node-gyp and npm)
gyp ERR! find Python - Set the environment variable PYTHON
gyp ERR! find Python - Set the npm configuration variable python:
gyp ERR! find Python   npm config set python "/path/to/pythonexecutable"
gyp ERR! find Python For more information consult the documentation at:
gyp ERR! find Python https://github.com/nodejs/node-gyp#installation
gyp ERR! find Python **********************************************************
gyp ERR! find Python
gyp ERR! configure error
gyp ERR! stack Error: Could not find any Python installation to use
        
npm ERR! [email protected] build: `node-gyp rebuild`
npm WARN Local package.json exists, but node_modules missing, did you mean to install?

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_cacache/_logs/2021-08-04T16_52_45_598Z-debug.log

@jweilhammer
Copy link
Contributor Author

jweilhammer commented Aug 5, 2021

@Flydiverny any status on this e2e failure, or any way for me to re-run the build?

Also thanks for the quick responses so far, much appreciated :-)

Edit: Tried to rebase and reword to push the same commit to trigger rebuild, did not work. Seems rebuild will need to be done manually by an admin

@Flydiverny
Copy link
Member

a bit confused why the builds are failing. Seems like the same error was silently failing in the docker build as well, some optional dependency. Not sure why E2E would fail tho, dockerfiles are close to identical 😅 Trying to address the dependency in question in #818

@Flydiverny
Copy link
Member

Right! Solved in #819, underlying issue being use of deprecated kubectl flags and the kubectl version was updated in the runner (which is just using ubuntu-latest, so guess it got updated recently with new releases).

Should work if you can rebase :)

@jweilhammer
Copy link
Contributor Author

@Flydiverny rebased off of upstream master, should be good to run!

I do need your help to click the buttons though since I'm a first time contributor:

2 workflows awaiting approval
First-time contributors need a maintainer to approve running workflows

@Flydiverny Flydiverny merged commit 43eb046 into external-secrets:master Aug 5, 2021
@Flydiverny
Copy link
Member

Cheers! Released in 8.3.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants