feat: Upsert secrets only when needed

[stephenthedev]

This implements a rudimentary data check on secrets polled to only call put/post actions when the data of the secret has changed.

This is aimed at resolving #737

[stephenthedev]

@moolen @Flydiverny Can you help kick off CI? Thanks!

[moolen]

LGTM so far, thank you! I want to check out your branch and do some manual testing.

[stephenthedev]

@moolen awesome thanks! Looking forward to this landing for our use case :-)

[moolen]

I tested it locally but found that it wasn't working because some metadata fields were present:

// new metadata (from `secretManifest`)
{
    "labels": {
        "secretLabel": "Hellofoo123"
    },
    "name": "e2e-secretmanager-template-sql65h62hxarnqjmpgkj4",
    "ownerReferences": [
        {
            "apiVersion": "kubernetes-client.io/v1",
            "controller": true,
            "kind": "ExternalSecret",
            "name": "e2e-secretmanager-template-sql65h62hxarnqjmpgkj4",
            "uid": "b13c2a96-5258-4ec5-be37-7217aec71220"
        }
    ]
}
// current metadata (from `kubeSecret`)
{
    "name": "e2e-secretmanager-template-sql65h62hxarnqjmpgkj4",
    "labels": {
        "secretLabel": "Hellofoo123"
    },
    "managedFields": [
        {
            // ...
        }
    ]
}

I suggested two things in the comments. it would be great to have e2e tests for that (i did them manually today) but i don't have an approach for your right now that from the top of my head. Maybe you can figure something out if you have the time for it.

[stephenthedev]

@moolen made the change. As for the e2e test, we don't have any existing instrumentation to trap calls made to the API so that'd be a bit of a lift to assert some of that. Given its now an allow list, I think the vector for that becomes pretty small. What do you think?

[stephenthedev]

Thinking about this more, the allowList also makes the unit test a lot more accurate in asserting the behavior, so maybe the e2e is overkill?

[moolen]

Given its now an allow list, I think the vector for that becomes pretty small. What do you think?

Sure, that works for me!

[moolen]

LGTM! Thanks for your contribution 🎉

[stephenthedev]

@moolen Awesome thank you for the review! What is the release cadence for this?

[Flydiverny]

@stephenthedev I made a release now :)
Thanks for the contribution!

[stephenthedev]

Amazing thank you both!