This repository has been archived by the owner on Jul 26, 2022. It is now read-only.
Ensure that the restart timer is always started #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flydiverny
approved these changes
Jun 2, 2021
Flydiverny
reviewed
Jun 2, 2021
|
This took me an embarrassingly long time to figure out and make sure I reproduced it correctly. =] |
… there are events or not
|
Did a rebase just to remove the silly semicolon removal |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #763
If there are no data events, the reset timer is never started. If the connection to the kube api server is lost during this time and new events come in they are never seen and the stream is never restarted.
Repro: (I used minikube with ssh access)
Install helm chart
minikube sshDrop current connection from pod to api server: e.g.
conntrack -D conntrack -s 172.17.0.6 -d 10.96.0.1Create a new example secret (failures to connect don't matter here)
Note that the secret is not picked up nor is the server restarted.
kubectl get externalsecrets.kubernetes-client.ioCredit and thanks to #362 (comment) for the iptables idea.