feat!: drop helm v2 and builtin CRD management #663
Conversation
Flydiverny
force-pushed
the
drop-helm2
branch
2 times, most recently
from
9feda3a
to
ec0082a
Compare
Signed-off-by: Markus Maga <[email protected]>
| @@ -34,7 +33,8 @@ async function main () { | |||
| logger.info('loading kube specs') | |||
| await kubeClient.loadSpec() | |||
| logger.info('successfully loaded kube specs') | |||
| await customResourceManager.manageCrd({ customResourceManifest }) | |||
|
|
|||
| kubeClient.addCustomResourceDefinition(customResourceManifest) | |||
There was a problem hiding this comment.
This wires up kubeClients fluent api it was dones inside customResourceManager before.
This is in reality just two different things but I've kind of combined them in my head 😄 When helm 3 support was introduced we discussed a bit and the option to disable the built in CRD management was added with a note to it being removed eventually. Now the only option remaining will be installing the CRDs thru helm or manually and KES runtime will leave it alone 😄 |
Since Helm 2 is EOL this drops helm 2 support and simplifies docs and removes the built in CRD handling depending entirely on them being installed by the user manually or thru helm.