This repository has been archived by the owner on Jul 26, 2022. It is now read-only.
feat(aws): allow custom endpoints for aws services #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: S.Cavallo <[email protected]>
Signed-off-by: S.Cavallo <[email protected]>
moolen
suggested changes
Jan 30, 2021
Flydiverny
changed the title
Signed-off-by: smcavallo <[email protected]>
moolen
approved these changes
Feb 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow custom endpoints for aws services
Useful if you need to use the FIPS endpoints -> https://docs.aws.amazon.com/general/latest/gr/asm.html
Or less likely use case if you need to override to use VPC endpoints when using custom DNS -> https://docs.aws.amazon.com/secretsmanager/latest/userguide/vpc-endpoint-overview.html
kubernetes-external-secrets is amazing and FIPS support is required for running it in fedRAMP compliant environments.
Signed-off-by: S.Cavallo [email protected]