Skip to content
This repository has been archived by the owner on Jul 26, 2022. It is now read-only.

AWS Secrets Manager: Support versionId #436

Merged
merged 3 commits into from
Jul 14, 2020

Conversation

sonots
Copy link
Contributor

@sonots sonots commented Jul 14, 2020

This PR resolves #435.

Added supporting versionId of AWS Secrets Manager.

Copy link
Member

@Flydiverny Flydiverny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Just 2 minor nitpicky comments because I'm like that 😉

lib/backends/secrets-manager-backend.js Outdated Show resolved Hide resolved
lib/backends/secrets-manager-backend.js Outdated Show resolved Hide resolved
@Flydiverny Flydiverny self-assigned this Jul 14, 2020
@Flydiverny Flydiverny merged commit 95827bc into external-secrets:master Jul 14, 2020
@sonots
Copy link
Contributor Author

sonots commented Jul 14, 2020

thx!

@sonots sonots deleted the versionId branch July 14, 2020 17:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Support versionId of AWS Secrets Manager
2 participants