Skip to content
This repository has been archived by the owner on Jul 26, 2022. It is now read-only.

Switch to human-readable log levels #429

Merged
merged 5 commits into from
Jul 14, 2020
Merged

Switch to human-readable log levels #429

merged 5 commits into from
Jul 14, 2020

Conversation

davidcorbin
Copy link
Contributor

Switch from the following log messages:

{"level":30,"time":1594499119283,"pid":18,"hostname":"kubernetes-external-secrets-56d5969cd6-gdkb4","msg":"starting poller for asdf/database-credentials"}

to

{"level":"info","time":1594499119283,"pid":18,"hostname":"kubernetes-external-secrets-56d5969cd6-gdkb4","msg":"starting poller for asdf/database-credentials"}

Many log aggregation tools parse the logs for human readable log levels like "warning" or "error". This makes it easier to send alerts based on those logs, etc.

@Flydiverny
Copy link
Member

I wouldn't be opposed to changing this, but just straight up changing it would be a breaking change. Would probably be better having it configurable and keeping the current default for existing users.

@davidcorbin
Copy link
Contributor Author

Good point about keeping the legacy format. I've switched the configuration to an env var and added the variable to the helm chart.

@Flydiverny Flydiverny self-assigned this Jul 14, 2020
@Flydiverny Flydiverny merged commit 4602ad0 into external-secrets:master Jul 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants