Skip to content
This repository has been archived by the owner on Jul 26, 2022. It is now read-only.

feat: add support for using either Vault k/v 1 or k/v 2 #426

Merged
merged 3 commits into from
Jul 12, 2020

Conversation

Flydiverny
Copy link
Member

@Flydiverny Flydiverny commented Jul 8, 2020

Closes #299
Fixes #248
Closes #425
Closes #349

Adds a kvVersion flag to vault backend:

apiVersion: 'kubernetes-client.io/v1'
kind: ExternalSecret
metadata:
  name: database-credentials-from-kv1
spec:
  backendType: vault
  vaultMountPoint: my-kubernetes-vault-mount-point
  vaultRole: my-vault-role
  kvVersion: 1 # <---------- K/V version to be able to parse api response correctly
  data:
    - name: username
      key: kv/database
      property: db-username
    - name: password
      key: kv/database
      property: db-password

@Flydiverny Flydiverny requested a review from silasbw July 8, 2020 18:40
@silasbw
Copy link
Contributor

silasbw commented Jul 12, 2020

Awesome 💯

@silasbw silasbw merged commit 4193050 into external-secrets:master Jul 12, 2020
@Flydiverny Flydiverny deleted the vault-kv-1-and-2 branch July 12, 2020 23:18
@dirtycajunrice
Copy link

dirtycajunrice commented Jul 15, 2020

moved to #439

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants