Skip to content
This repository has been archived by the owner on Jul 26, 2022. It is now read-only.

Fixed dataFrom property in naming convention verification #292

Merged
merged 3 commits into from
Mar 25, 2020
Merged

Fixed dataFrom property in naming convention verification #292

merged 3 commits into from
Mar 25, 2020

Conversation

Strange-Account
Copy link
Contributor

No description provided.

Flydiverny
Flydiverny suggested changes Mar 1, 2020
View reviewed changes
Copy link
Member

@Flydiverny Flydiverny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but can we add a test case or two for dataFrom branch

@Flydiverny
Copy link
Member

#291

@Strange-Account
Copy link
Contributor Author

What test case(s) do you mean?

@Flydiverny
Copy link
Member

I think adding a variation or two to the existing test case for naming conventions
https://github.com/godaddy/kubernetes-external-secrets/blob/master/lib/poller.test.js#L757

to make sure it tests the codepath for dataFrom usage also and not only the data variant, so they work independently, and combined.

@Flydiverny Flydiverny self-assigned this Mar 25, 2020
@Flydiverny Flydiverny merged commit f26bf2b into external-secrets:master Mar 25, 2020
@Flydiverny Flydiverny mentioned this pull request Mar 25, 2020
Closed
@Flydiverny Flydiverny mentioned this pull request Jun 2, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Flydiverny Flydiverny Flydiverny approved these changes

Assignees

@Flydiverny Flydiverny

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Strange-Account @Flydiverny @Schnurbus