This repository has been archived by the owner on Jul 26, 2022. It is now read-only.
Enforcing naming conventions for AWS Secrets Manager (and HashiCorp Vault) entries #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muenchhausen
changed the title
|
Documentation is missing for both useages
I will add that, if this pull request is of interest. |
Flydiverny
reviewed
Nov 26, 2019
silasbw
previously requested changes
Nov 26, 2019
There was a problem hiding this comment.
Thanks for this contribution 🥂
Do you have any examples of similar operations performed in native Kubernetes objects or well-known extensions? I'm curious how those approaches compare to this one.
We'll also need some updates to the docs explaining how to use this.
also improved wording for naming permitted annotation related #178
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #178.
This patch is tested. It runs smoothly on two clusters since more than 4 weeks.