This repository has been archived by the owner on Jul 26, 2022. It is now read-only.
feat: basic metrics #147
Merged
feat: basic metrics #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silasbw
reviewed
Aug 21, 2019
Signed-off-by: Moritz Johner <[email protected]>
|
thank you <3 |
keweilu
reviewed
Aug 21, 2019
anarcher
pushed a commit
to anarcher/kubernetes-external-secrets
that referenced
this pull request
Oct 30, 2019
* feat: basic metrics Signed-off-by: Moritz Johner <[email protected]> * chore: update chart docs & env vars
Flydiverny
pushed a commit
to Flydiverny/kubernetes-external-secrets
that referenced
this pull request
Nov 3, 2019
* feat: basic metrics Signed-off-by: Moritz Johner <[email protected]> * chore: update chart docs & env vars
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR Introduces a HTTP Server component that serves Prometheus metrics. We want metrics for this application to gain insights into the app and its integration with 3rd party APIs:
This PR adds the
sync_callsmetric with labelsname|namespace|backend|statusthat provide visibility for the above criteria.