Skip to content
This repository has been archived by the owner on Jul 26, 2022. It is now read-only.

feat(json): support JSON objects in AWS Secret Manager #13

Merged
merged 1 commit into from
Feb 18, 2019
Merged

Conversation

silasbw
Copy link
Contributor

@silasbw silasbw commented Feb 18, 2019

This is useful (required?) to safely rotate secrets atomically, like a client
certificate and private key.

This is useful (required?) to safely rotate secrets atomically, like a client
certificate and private key.
@silasbw silasbw requested review from jcrugzz and removed request for jcrugzz February 18, 2019 19:41
Copy link

@jcrugzz jcrugzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idk if there are any side effects to this but it looks fine to me overall.

@silasbw silasbw merged commit cd7130f into master Feb 18, 2019
@silasbw silasbw deleted the object0 branch February 18, 2019 19:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants