Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use standalone purrr #408

Merged
merged 7 commits into from
Nov 26, 2024
Merged

use standalone purrr #408

merged 7 commits into from
Nov 26, 2024

Conversation

JosiahParry
Copy link
Contributor

No description provided.

@JosiahParry
Copy link
Contributor Author

This PR removes {purrr} as a dependency by using the standalone purrr from https://github.com/r-lib/rlang/blob/main/R/standalone-purrr.R

This doesn't have full coverage of purrr functionality but I believe I've handled all the edge cases.

README.Rmd Outdated Show resolved Hide resolved
@Ilia-Kosenkov
Copy link
Member

Dropping a dependency is worth mentioning on the NEWS.md.

@JosiahParry
Copy link
Contributor Author

<3 thank you!

@JosiahParry JosiahParry merged commit 4217a0e into main Nov 26, 2024
17 checks passed
@JosiahParry JosiahParry deleted the standalone-purrr branch November 26, 2024 19:30
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 97.29730% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.10%. Comparing base (b20d88c) to head (8632d20).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
R/toml_serialization.R 87.50% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
R/create_extendr_package.R 100.00% <100.00%> (ø)
R/eval.R 100.00% <100.00%> (ø)
R/find_exports.R 100.00% <100.00%> (ø)
R/function_options.R 92.18% <100.00%> (ø)
R/generate_toml.R 100.00% <100.00%> (ø)
R/sanitize_code.R 98.90% <100.00%> (-0.05%) ⬇️
R/source.R 76.41% <100.00%> (ø)
R/track_rust_source.R 97.36% <100.00%> (ø)
R/toml_serialization.R 82.05% <87.50%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants