[CI] Enable code cov status checks and aim at 70% of coverage #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems current codecov status checks are enough, closing this for now. |
Ilia-Kosenkov
changed the title
JosiahParry
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
In general, I'm happy to have codecov be useful so that we don't merge untested R code. This will prevent any future accidental breaks. I don't hope that this doesn't result in more snapshot tests though!
As I understand it, this PR requires that any PR have have least 70% code coverage. I'm quite okay with this. And if it will help us get to releasable states, I think it is good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to try out getting more info on code coverage in PRs.