Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify usage of conventional-version and conventional-release #152

Open
olekhal opened this issue Jun 17, 2020 · 2 comments
Open

clarify usage of conventional-version and conventional-release #152

olekhal opened this issue Jun 17, 2020 · 2 comments
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@olekhal
Copy link

olekhal commented Jun 17, 2020

The current examples for using conventional-version and conventional-release will no longer work. This is caused by a change in actions/checkout@v2 which no longer fetches tags by default. In v2 the default changed to only fetch the last commit.

to get the same behavior with v2 as in v1 it is necessary to use the fetch-depth:0 option

- uses: actions/checkout@v2
  with:
    fetch-depth: 0
@olekhal olekhal added the documentation Improvements or additions to documentation label Jun 17, 2020
@sasjo
Copy link
Contributor

sasjo commented Jun 17, 2020

I'm aware of this and I think we should update all examples to use checkout@v2 in the right way.
The checkout@v2 action also renders our setup-git action moot as it will configure git CLI with the token credentials so it can be used in scripts.

@nikolay-bocharov
Copy link

The documentation for conventional-release is still stale

@sasjo sasjo added the good first issue Good for newcomers label Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants