-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: replace travis with github action #1259
Merged
ctcpip
merged 19 commits into
expressjs:master
from
inigomarquinez:ci/migrate-travis-to-gh-actions
Jun 13, 2024
Merged
ci: replace travis with github action #1259
ctcpip
merged 19 commits into
expressjs:master
from
inigomarquinez:ci/migrate-travis-to-gh-actions
Jun 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…quinez/expressjs-multer into ci/migrate-travis-to-gh-actions
…quinez/expressjs-multer into ci/migrate-travis-to-gh-actions
UlisesGascon
approved these changes
May 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
ctcpip
requested changes
May 29, 2024
Co-authored-by: Chris de Almeida <[email protected]>
ctcpip
requested changes
Jun 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
package-lock.json
should not be added
Is this PR ready to be merged? Do you need me to do something else? |
ctcpip
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the CI pipeline from travis to GitHub actions and adds node version 11 to 22 to the matrix.
The travis project should be removed after merging the PR (see here).
The CI pipeline works in my local fork.
Related to jshttp/http-errors#108