Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE8 Bug #13

Closed
arlolra opened this issue Feb 9, 2012 · 3 comments
Closed

IE8 Bug #13

arlolra opened this issue Feb 9, 2012 · 3 comments

Comments

@arlolra
Copy link
Contributor

arlolra commented Feb 9, 2012

For some odd reason, IE8 isn't happy with this:
https://github.com/visionmedia/express-expose/blob/master/lib/express-expose.js#L218

var test = test || {}; causes a problem. I'm guessing it has something to do with hoisting replacing the global variable.

In any case, swapping this,

return (i ? '' : 'var ') + part + ' = ' + part + ' || {};';

with this,

return (i ? '' : 'window.') + part + ' = window.' + part + ' || {};';

gets around the problem. Not sure you want to do that, just thought I'd point it out.

@tj
Copy link
Member

tj commented Feb 9, 2012

crap yeah that's a bug on my part

@arlolra
Copy link
Contributor Author

arlolra commented Feb 9, 2012

want me to turn it into a pull request?

@tj
Copy link
Member

tj commented Feb 9, 2012

sure! that would be great

@tj tj closed this as completed in 413628d Feb 9, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants