Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript Definitions #7

Closed
blakeembrey opened this issue Mar 17, 2016 · 4 comments
Closed

TypeScript Definitions #7

blakeembrey opened this issue Mar 17, 2016 · 4 comments
Labels
top priority Issues which the TC deem our current highest priorities for the project

Comments

@blakeembrey
Copy link
Member

References: expressjs/express#2818, typings/typings#322, microsoft/TypeScript#7546.

Summary: For Express 5.x, support TypeScript by packaging definitions with the project. This is used by TypeScript automatically when you add typings to the package.json. As part of the effort, there needs to be a good CI step and process in place. As the author of @typings, I have plenty of background on solving the issue, but it should be as straight-forward as possible for everyone to be involved.

An initial PR demonstrating TypeScript definitions is available at pillarjs/path-to-regexp#72 and awaiting some review. Integration with CI will be an ongoing topic, the best process is having TypeScript test files which will do type checking and runtime checking. However, the linked issue above is one approach that can also work (comparing what TypeScript knows about the .js package and our hand written .d.ts file).

I'm opening this issue to give heads up and hopefully collaborate on the final solution for Express.js 5.x.

@fdrobidoux
Copy link

Any news on this?

@blakeembrey
Copy link
Member Author

Currently there's https://github.com/types/npm-express.

@daprahamian
Copy link

Would be interested in helping with this.

@wesleytodd wesleytodd added the top priority Issues which the TC deem our current highest priorities for the project label Feb 17, 2020
@wesleytodd
Copy link
Member

I am going to close this in favor of #192 where we can continue this conversation and make a plan for the immediate future on this topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
top priority Issues which the TC deem our current highest priorities for the project
Projects
None yet
Development

No branches or pull requests

4 participants