Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should isIntrinsicHeight prop make width/height optional (or even disallowed)? #356

Open
ppozniak opened this issue Mar 29, 2021 · 2 comments

Comments

@ppozniak
Copy link

I think it is confusing. I'd like to understand and maybe update the documentation - isIntrinsicHeight seems to make the ratio meaningless so why do naturalWidth and height still have to be passed in?

@Conor-Hinchee
Copy link
Collaborator

Hey @ppozniak! You have understood the isIntrinsicHeight prop correctly and the presence of isIntrinsicHeight does mean the props of naturalSlideHeight and naturalSlideWidth are no longer required since they aren't being used. We would appreciate any PR clarifying this in the documentation.

@ppozniak
Copy link
Author

Alrighty, thanks. I'll try to update types and documentation when I got a bit of free time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants