Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lighthouse accessibility test shows warnings #214

Open
paveli opened this issue Nov 26, 2019 · 3 comments
Open

Lighthouse accessibility test shows warnings #214

paveli opened this issue Nov 26, 2019 · 3 comments

Comments

@paveli
Copy link
Contributor

paveli commented Nov 26, 2019

  • pure-react-carousel version: 1.23.3
  • react version: 16.8.6
  • browser used: 78.0.3904.108
  • node version:

What you did:

Tested my website with Chrome's Lighthouse.

What happened:

Test showed few warnings related to carousel:

- Buttons do not have an accessible name
- Lists do not contain only <li> elements and script supporting elements (<script> and <template>).

Reproduction:

Test any website with pure-react-carousel on it.
Like: https://express-labs.github.io/pure-react-carousel/#de

Problem description:

Suggested solution:

Add aria markup to buttons.

Can you help us fix this issue by submitting a pull request?

Partly.
"Buttons do not have an accessible name" warning fixed in this PR: #213

@paveli
Copy link
Contributor Author

paveli commented Nov 27, 2019

Issue with dot buttons is fixed now. Thank you for accepting PR.
The second one (Lists do not contain only <li> elements) is not and I am not sure how to handle it myself. Hope someone will help.

@daiky00
Copy link

daiky00 commented Jul 27, 2020

@paveli is this going to be fix?

@tim-steele
Copy link
Contributor

@daiky00 @paveli opened a PR and we accepted his fix. It should be published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants