-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue: Still showing [native code] even with source maps #74
Comments
I'm having the same issue. However, it's not happening everywhere. I think it may be connected to the connect() function of Redux. Are you also using it? |
@bill-pairaktaridis yes. thank you for noticing that. This is also happening in more isolated areas as well. functional components that do not connect to a store (within their scope), but may well be imported by components that use connect. We are currently trying to remove redux, but that is a few months away from being complete. |
Yes, maybe one of the sentry-expo devs can help out here. In its current form it offers little in the way of actually debugging an issue. |
Pinging @HazAT as he wrote the |
When i tried to use the base I do not have any warnings about sourcemaps. It also looks like your code is getting some bundle information (onPress, touchableHandlePress), where as mine is just ending at |
@hellsan631 I'll try adding |
I am having this issue as well, anyone got any ideas? |
@cruzach @HazAT could you look into this? Update: I've forked The app size is still very large, as well, so I'm not sure the clean up task is running. Update: Upon further investigation, it looks that at least |
@b4stien I just got the same error shown on the Sentry dashboard ("Source code was not found"), it's due to the |
@cruzach it works indeed, thank you very much! |
I don't have any errors in my issues. But the code is still showing up minified and with no mapping to the source. I distinctly remember this working for a while (for me) before the upgrade to the unified Sentry JS SDK. |
@bill-pairaktaridis haven't been able to repro this behavior on sentry-expo: "2.0.1", yet. is that the version you're using? |
@cruzach I'm still seeing it. I'll try to set up a clean Expo project and test it on that. Could you also do a rudimentary Redux setup and see if that's the cause? Because right now, this is basically what all my issues look like. |
@hellsan631 did you get it to work? |
@cruzach did you try with a built app (I'm using App Bundles, as that's mandatory now for the Google Play Store)? |
@cruzach I'm seeing that in files that don't contain |
I don't believe it's I'll try and repro this, if you have time to put together a minimal example using redux that demonstrates this problem, feel free to link a repro |
I'm almost positive it has something to do with |
I was able to resolve this! The fault was on my end because I was catching all errors on my AppScreen.js with |
@bill-pairaktaridis how did you catch breadcrumbs as well? |
@hellsan631 I didn't. I just removed my |
Sentry docs appear to show how to resolve this. https://docs.sentry.io/platforms/javascript/react/#error-boundaries |
i think this occurs only for unhandled promise rejections on android see: @HazAT curious if this is an issue specific to |
@cruzach yes that's what I've surmised as well. I keep getting a couple every day that are all promise rejections that I'm apparently not handling somewhere in the code. Hard to troubleshoot though without any stack trace. |
i think this is a duplicate of #4 |
check if your source map was published with success:
|
Heads up that I see this same behavior when I call |
Any information I can provide to solve this issue? Or any advice I should check on my environment that could cause this issue? All the errors I'm getting are filled with [native code] and I'm not able to pinpoint any errors from the production environment. |
I believe this was an upstream sentry issue (getsentry/sentry-react-native#1077) and was just recently fixed. Once a new release is published, you'll just need to remove your node modules and lockfile and reinstall |
Newest version of |
Really scratching my head here. I am unable to get source maps to correctly work in a provisioned version of sentry, using the latest version of expo & react native.
Releases is correctly set, sentry server version is 9.1.2,
expo: "34.0.4", sentry-expo: "2.0.0",
Using the post took to upload our source maps, we are still seeing "native code"
Even though this is thrown inside javascript, with build artifacts existing for that release.
The text was updated successfully, but these errors were encountered: