100% test coverage #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vonovak
approved these changes
Sep 12, 2024
This is useful for testing, and potentially useful with slow network conditions.
After running `jest --coverage`, this directory contains `.js` files, which the compiler will attempt to check, and even build.
nicknovitski
force-pushed
the
gzip-sync
branch
from
8184ba0
to
bf9cddd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #89 +/- ##
===========================================
+ Coverage 98.29% 100.00% +1.70%
===========================================
Files 2 2
Lines 176 168 -8
Branches 36 32 -4
===========================================
- Hits 173 168 -5
+ Misses 2 0 -2
+ Partials 1 0 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that with the codecov action broken, coverage had dropped without us noticing (#88), but not very far. It was easy to bring it back and add a threshold to keep it there.