Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eas update and eas build created .jsbundle can be different if env vars .eas.json and actions .env vars are different #302

Open
mfazekas opened this issue Sep 7, 2024 · 0 comments

Comments

@mfazekas
Copy link

mfazekas commented Sep 7, 2024

Topic and scope of discussion

continuous-deploy-fingerprint sometimes call eas update if fingerprint matches and eas build if it doesn't.

  • eas update picks environment variable form env: set in GitHub actions. docs
  • eas build picks environment variables from eas.json docs

This can cause continuous-deploy-fingerprint actions to produce different jsbundle for update vs build.

Motivation

Building different .jsbundle for update vs build can be problematic. And while the expo docs mentions this for EAS Build and EAS Update this can be suprising for continuous-deploy-fingerprint consumers.

Additional context

https://github.com/mfazekas/env-sample demonstrates the issue

Not sure if this can/should be fixed/warned/documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant