This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
add better warning when prebuilding in non-interactive mode #4456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsokal
approved these changes
Jul 5, 2022
EvanBacon
reviewed
Jul 8, 2022
| @@ -104,6 +104,9 @@ export async function promptToClearMalformedNativeProjectsAsync( | |||
| initial: true, | |||
| })) | |||
| ) { | |||
| if (isNonInteractive()) { | |||
There was a problem hiding this comment.
It's unclear if any changes landed here will be published, I recommend opening here https://github.com/expo/expo/blob/main/packages/%40expo/cli/src/prebuild/clearNativeFolder.ts
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
currently, if someone has a managed project with an ios directory, or is writing eas secrets to ios directory e.g.
then only warning they are getting that ios directory is deleted is log
How
print working when rebuilding in non-interactive mode
Test Plan