From 3a1faa5fb0bd01f8e416e77f543cbfbd9310addd Mon Sep 17 00:00:00 2001 From: Jon Samp Date: Wed, 28 Dec 2022 23:44:38 -0600 Subject: [PATCH 1/2] Makes eas.json configuration to only run on update:configure --- packages/eas-cli/src/commands/update/configure.ts | 7 ++++++- packages/eas-cli/src/update/configure.ts | 4 +--- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/packages/eas-cli/src/commands/update/configure.ts b/packages/eas-cli/src/commands/update/configure.ts index 8f075e41a0..826629dc1a 100644 --- a/packages/eas-cli/src/commands/update/configure.ts +++ b/packages/eas-cli/src/commands/update/configure.ts @@ -5,7 +5,10 @@ import EasCommand from '../../commandUtils/EasCommand'; import { EASNonInteractiveFlag } from '../../commandUtils/flags'; import Log from '../../log'; import { RequestedPlatform } from '../../platform'; -import { ensureEASUpdateIsConfiguredAsync } from '../../update/configure'; +import { + ensureEASUpdateIsConfiguredAsync, + ensureEASUpdateIsConfiguredInEasJsonAsync, +} from '../../update/configure'; export default class UpdateConfigure extends EasCommand { static override description = 'configure the project to support EAS Update'; @@ -46,6 +49,8 @@ export default class UpdateConfigure extends EasCommand { platform, }); + await ensureEASUpdateIsConfiguredInEasJsonAsync(projectDir); + Log.addNewLineIfNone(); Log.log(`๐ŸŽ‰ Your app is configured with EAS Update!`); Log.newLine(); diff --git a/packages/eas-cli/src/update/configure.ts b/packages/eas-cli/src/update/configure.ts index d1c78845ca..270172692f 100644 --- a/packages/eas-cli/src/update/configure.ts +++ b/packages/eas-cli/src/update/configure.ts @@ -258,7 +258,7 @@ async function ensureEASUpdateIsConfiguredNativelyAsync( * Make sure EAS Build profiles are configured to work with EAS Update by adding channels to build profiles. */ -async function ensureEASUpdateIsConfiguredInEasJsonAsync(projectDir: string): Promise { +export async function ensureEASUpdateIsConfiguredInEasJsonAsync(projectDir: string): Promise { const easJsonPath = EasJsonAccessor.formatEasJsonPath(projectDir); if (!(await fs.pathExists(easJsonPath))) { @@ -363,8 +363,6 @@ export async function ensureEASUpdateIsConfiguredAsync( workflows, }); - await ensureEASUpdateIsConfiguredInEasJsonAsync(projectDir); - if (projectChanged || !hasExpoUpdates) { await ensureEASUpdateIsConfiguredNativelyAsync(graphqlClient, { exp: expWithUpdates, From 37bdbe8af17fc750570d6a1cfa54beef42c8c3a8 Mon Sep 17 00:00:00 2001 From: Jon Samp Date: Thu, 29 Dec 2022 05:54:26 +0000 Subject: [PATCH 2/2] update CHANGELOG.md --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index f5fd1b8f21..a429c461fd 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -12,6 +12,8 @@ This is the log of notable changes to EAS CLI and related packages. ### ๐Ÿ› Bug fixes +- Makes eas.json configuration to only run on `update:configure`. ([#1598](https://github.com/expo/eas-cli/pull/1598) by [@jonsamp](https://github.com/jonsamp)) + ### ๐Ÿงน Chores ## [3.1.1](https://github.com/expo/eas-cli/releases/tag/v3.1.1) - 2022-12-19