-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[eas-cli] Adds channels to build profiles on eas update:configure #1570
[eas-cli] Adds channels to build profiles on eas update:configure #1570
Conversation
ENG-7030 Add channel to build profiles on eas update:configure
|
/changelog-entry new-feature add channel configurations to eas.json during |
Size Change: +223 B (0%) Total Size: 40.3 MB
|
Codecov Report
@@ Coverage Diff @@
## main #1570 +/- ##
==========================================
- Coverage 51.24% 51.16% -0.08%
==========================================
Files 461 461
Lines 16025 16065 +40
Branches 3158 3165 +7
==========================================
+ Hits 8211 8218 +7
- Misses 7799 7832 +33
Partials 15 15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting changes mostly because this doesn't work with eas.json with JSON5.
Co-authored-by: Dominik Sokal <[email protected]>
Co-authored-by: Dominik Sokal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the JSON5 part, seems good 👍
Co-authored-by: Dominik Sokal <[email protected]>
Checklist
/changelog-entry [breaking-change|new-feature|bug-fix|chore] [message]
and CHANGELOG.md will be updated automatically.Why
To make EAS Update easier to set up, we are adding
channel
properties to build profiles when runningeas update:configure
.The logic is:
eas build:configure
, then re-runeas update:configure
to set everything up.In addition, I updated the "Next steps" text, so there's actionable items after running
eas update:configure
.Test Plan
Run
easd update:configure
in a project. Check:eas update:configure