Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] Adds channels to build profiles on eas update:configure #1570

Merged
merged 11 commits into from
Dec 12, 2022

Conversation

jonsamp
Copy link
Member

@jonsamp jonsamp commented Dec 7, 2022

Checklist

  • I've added an entry to CHANGELOG.md if necessary. You can comment this pull request with /changelog-entry [breaking-change|new-feature|bug-fix|chore] [message] and CHANGELOG.md will be updated automatically.

Why

To make EAS Update easier to set up, we are adding channel properties to build profiles when running eas update:configure.

The logic is:

  • If eas.json is present:
    • if there is not pre-existing channel or release channel, set a channel named after the profile name
    • else do nothing (leave as is)
  • else warn that the developer may need to run eas build:configure, then re-run eas update:configure to set everything up.

In addition, I updated the "Next steps" text, so there's actionable items after running eas update:configure.

Screenshot 2022-12-07 at 12 47 10 PM

Test Plan

Run easd update:configure in a project. Check:

  • that projects with channels in build profiles are not overwritten
  • that projects with release channels in build profiles are not overwritten
  • that projects get a channel when none is specified after running eas update:configure
  • that if eas.json is not present, you see a readable error message

@linear
Copy link

linear bot commented Dec 7, 2022

ENG-7030 Add channel to build profiles on eas update:configure

  • if channel already exists, do not overwrite it (keep it)
  • if releaseChannel is set, do not set channel
  • if no channel/no releaseChannel, then write channel to each profile and name the value after the profile name.

@jonsamp
Copy link
Member Author

jonsamp commented Dec 7, 2022

/changelog-entry new-feature add channel configurations to eas.json during eas update:configure

@jonsamp jonsamp marked this pull request as ready for review December 7, 2022 18:58
@github-actions
Copy link

github-actions bot commented Dec 7, 2022

Size Change: +223 B (0%)

Total Size: 40.3 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 40.3 MB +223 B (0%)

compressed-size-action

@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Merging #1570 (cce63e9) into main (4e11707) will decrease coverage by 0.09%.
The diff coverage is 26.00%.

❗ Current head cce63e9 differs from pull request most recent head 86afa2e. Consider uploading reports for the commit 86afa2e to get more accurate results

@@            Coverage Diff             @@
##             main    #1570      +/-   ##
==========================================
- Coverage   51.24%   51.16%   -0.08%     
==========================================
  Files         461      461              
  Lines       16025    16065      +40     
  Branches     3158     3165       +7     
==========================================
+ Hits         8211     8218       +7     
- Misses       7799     7832      +33     
  Partials       15       15              
Impacted Files Coverage Δ
packages/eas-cli/src/update/configure.ts 11.68% <12.00%> (-0.60%) ⬇️
packages/eas-cli/src/commands/update/configure.ts 33.34% <12.50%> (-19.60%) ⬇️
packages/eas-cli/src/commands/update/index.ts 16.52% <50.00%> (ø)
packages/eas-cli/src/commands/build/run.ts 24.10% <100.00%> (ø)
packages/eas-cli/src/run/android/emulator.ts 23.53% <100.00%> (ø)
packages/eas-json/src/accessor.ts 92.50% <100.00%> (+0.40%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@dsokal dsokal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes mostly because this doesn't work with eas.json with JSON5.

packages/eas-cli/src/commands/update/configure.ts Outdated Show resolved Hide resolved
packages/eas-cli/src/commands/update/configure.ts Outdated Show resolved Hide resolved
packages/eas-cli/src/update/configure.ts Outdated Show resolved Hide resolved
packages/eas-cli/src/update/configure.ts Outdated Show resolved Hide resolved
packages/eas-cli/src/update/configure.ts Outdated Show resolved Hide resolved
packages/eas-cli/src/update/configure.ts Outdated Show resolved Hide resolved
packages/eas-cli/src/update/configure.ts Outdated Show resolved Hide resolved
Copy link
Member

@byCedric byCedric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the JSON5 part, seems good 👍

@wschurman wschurman removed their request for review December 9, 2022 05:51
packages/eas-cli/src/update/configure.ts Outdated Show resolved Hide resolved
@jonsamp jonsamp merged commit 5203096 into main Dec 12, 2022
@jonsamp jonsamp deleted the jon/eng-7030-add-channel-to-build-profiles-on-eas branch December 12, 2022 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants