eas submit does not use environment variables from eas.json

[gerwim]

Summary

When running eas submit --platform ios --profile tst --latest it returns an error.

Managed or bare?

Managed

Environment

EAS CLI 0.40.0 environment info:
System:
OS: Windows 10 10.0.22000
Binaries:
Node: 14.18.0 - C:\Program Files\nodejs\node.EXE
Yarn: 1.22.15 - ~\AppData\Roaming\npm\yarn.CMD
npm: 6.14.15 - C:\Program Files\nodejs\npm.CMD
Utilities:
Git: 2.31.1.
npmPackages:
@expo/webpack-config: ^0.16.2 => 0.16.4
expo: ^43.0.0 => 43.0.0
react: 17.0.1 => 17.0.1
react-dom: 17.0.1 => 17.0.1
react-native: 0.64.3 => 0.64.3
react-native-web: 0.17.1 => 0.17.1
Project workflow: managed

Error output

Failed to resolve bundleIdentifier in the Xcode project: Specify "ios.bundleIdentifier" in app.config.ts or app.json and run this command again..
Specify "ios.bundleIdentifier" in app.config.ts or app.json and run this command again.

Reproducible demo or steps to reproduce from a blank project

Init an EAS project with the following files:

eas.json

{
    "cli": {
      "version": ">= 0.38.3"
    },
    "build": {
      "development": {
        "developmentClient": true,
        "distribution": "internal"
      },
      "preview": {
        "distribution": "internal"
      },
      "tst": {
        "env": {
            "BUNDLE_IDENTIFIER": "my.app.development"
          }
      }
    },
    "submit": {
      "tst": {}
    }
  }

app.config.js

export default ({ config }) => {
    return {
        ...config,
        ios: {
            ...config.ios,
            bundleIdentifier: process.env.BUNDLE_IDENTIFIER,
        }
    };
};

It's probably the same underlying issue as #820.

When running an eas build with --auto-submit it works. But running eas submit seperately from the build does not.

[brentvatne]

this is expected behavior. we may need to document this more clearly, currently it's documented here: https://docs.expo.dev/build/automating-submissions/#build-profile-environment-variables-and-submissions

[hfllr]

Posting here because it's not an issue but more a inconsistency in the docs @brentvatne : here is described: "Remove any code that references Constants.manifest. That will now always return null." but here it is described how to get the env variables from eas.json using Constants.manifest (which is not working).

Sorry if it's the wrong place to share this, but I wasn't sure where to post this. Its driving me crazy because I couldnt figure out a way to retreive the env variables of eas.json

[Userrrfriendly]

@hfllr So did you have any luck retrieving the env variables of eas.json? I'm still struggling with this issue.

[bartvanandel]

We are having a bit of trouble getting eas submit to use the correct configuration due to this lack of support for env in the submit configuration as well.

We use some logic in app.config.ts to create an runtime environment specific app id (e.g. "com.example.app" for prod, "com.example.app.dev" for dev; same with app name so Apple doesn't complain). However, this only works for eas build and eas update (last one untested by us so far). It would be very beneficial if environment can be read from the submit config as well, e.g.:

{
  build: {...},
  submit: {
    base: {...},
    dev: {
      extends: 'base',
      env: {
        APP_ENV: 'dev'
      },
    },
    prod: {
      extends: 'base',
      env: {
        APP_ENV: 'prod'
      }
    },
    'prod:beta': {
      extends: 'prod',
      android: {
        track: 'internal',
      },
      // etc
    },
  },
}

[hfllr]

@Userrrfriendly sorry for the late reply, but no not yet. I'm currently using 'process.env.NODE_ENV' inside the code to make the necessary distinction where needed. This doesn't allow for custom environments, but at least distinguishes dev from prod.

[jessemezini]

See: https://docs.expo.dev/eas/json/#bundleidentifier

"..but if you have multiple Xcode schemes and targets, this value might be necessary."

"submit": { "staging": { "ios": { "..." "bundleIdentifier": "com.exampledev" } } }